Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: define KVFilter for customized mutation initialization #24021

Merged
merged 16 commits into from
Apr 15, 2021
Merged

store/tikv: define KVFilter for customized mutation initialization #24021

merged 16 commits into from
Apr 15, 2021

Conversation

sticnarf
Copy link
Contributor

What problem does this PR solve?

Part of #22513

tablecodec.IsUntouchedIndexKValue is a TiDB specific optimization. It should not be used in the store/tikv package.
For such custom kv initialization requirements, a KVFilter is defined for TiKV client users.

Check List

Tests

  • Unit test

Release note

  • No release note

@sticnarf
store/tikv: define KVFilter for customized mutation initialization
6d5d454 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf sticnarf added the sig/transaction SIG:Transaction label Apr 14, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
AndreMouche
AndreMouche reviewed Apr 15, 2021
View reviewed changes
store/tikv/2pc.go
if len(value) > 0 {
if tablecodec.IsUntouchedIndexKValue(key, value) {
if isUnnecessaryKV {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only un-empty value need the filter, so could we move the filter logic in L350~L351?

AndreMouche
AndreMouche reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@sticnarf
address comment
9c4ce26 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@sticnarf
Copy link
Contributor Author

sticnarf commented Apr 15, 2021 •
edited
Loading

Seems the test failed, let me see what is wrong...

Ah, it's a test inside tikv that wants to remove untouched index...

@sticnarf
fix a failing unit test
d4528b7 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
AndreMouche
AndreMouche approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d4528b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@AndreMouche
Copy link
Contributor

/run-tics-test

@AndreMouche
Copy link
Contributor

/run-unit-test

@AndreMouche
Copy link
Contributor

/merge

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@disksing
Copy link
Contributor

/run-all-tests

@disksing
Copy link
Contributor

@sticnarf CI fail.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@disksing disksing added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bdcb96f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@disksing
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member

@sticnarf: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit c46cc91 into pingcap:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@disksing disksing disksing approved these changes

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sticnarf @ti-chi-bot @AndreMouche @zhouqiang-cl @disksing @Rustin170506